-
Notifications
You must be signed in to change notification settings - Fork 39
Enable minimize option to Llama Dialog #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying opendataeditor with
|
| Latest commit: |
5c58d2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31ce6136.opendataeditor.pages.dev |
| Branch Preview URL: | https://1027-minimize-ai-dialog.opendataeditor.pages.dev |
romicolman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
romicolman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked this on Mac. Here is my feedback:
When you select a different dataset from the sidebar, the warning dialog pops up, but if you click on Cancel, you don't see the prompt dialog again.
This is the workflow that I suggest:
- The user clicks on a different dataset.
- The AI prompt dialog is maintain on the background.
- The warning dialog pops-up.
- If the user clicks on Cancel, the warning dialog disappears and the prompt one is kept.
- If the user clicks OK, the warning and the prompt dialogs are closed.
romicolman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
romicolman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address this PR after the release.

WIP Fixes #1027
TODO: