Skip to content

Conversation

@pdelboca
Copy link
Member

@pdelboca pdelboca commented Sep 9, 2025

WIP Fixes #1027

TODO:

  • What should happen when the Dialog is minimized and the the user changes the dataset?

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 11, 2025

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c58d2c
Status: ✅  Deploy successful!
Preview URL: https://31ce6136.opendataeditor.pages.dev
Branch Preview URL: https://1027-minimize-ai-dialog.opendataeditor.pages.dev

View logs

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdelboca I've checked it. The minimize button implementation works OK. I've created a new ticket (issue #1040) to address the second scenario.

@pdelboca pdelboca requested a review from rustico September 22, 2025 11:11
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked this on Mac. Here is my feedback:

When you select a different dataset from the sidebar, the warning dialog pops up, but if you click on Cancel, you don't see the prompt dialog again.

This is the workflow that I suggest:

  • The user clicks on a different dataset.
  • The AI prompt dialog is maintain on the background.
  • The warning dialog pops-up.
  • If the user clicks on Cancel, the warning dialog disappears and the prompt one is kept.
  • If the user clicks OK, the warning and the prompt dialogs are closed.

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comment apart from the one above. The text in the AI dialog:

Captura de pantalla 2025-09-29 a las 11 00 00

Adjustments:

Changing THE dataset will cancel the AI WORK. Do you want to proceed?

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address this PR after the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AI feature closes when clicking on the main screen

3 participants