-
Notifications
You must be signed in to change notification settings - Fork 65
feat: converting to use typescript, functional components and upgrading to eslint 9 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@okonet Can you update the netlify build to run build:storybook and to publish the public directory? I believe that should fix the deploy. I converted your style guide documentation into storybook documentation. Let me know if there are any other changes that you would like me to make. I believe this might be a breaking change since we won't require the type package anymore @types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making this. I think it's a good first step to modernize the library! Very much appreciated.
export default { | ||
"*": (filenames) => [`eslint ${filenames.join(" ")} --fix`, "git add"], | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git add
command isn't needed and I also think this can be simplified further but that's fine for now.
I think just this:
export default { | |
"*": (filenames) => [`eslint ${filenames.join(" ")} --fix`, "git add"], | |
}; | |
{ | |
"*": "eslint --fix", | |
}; |
as a .lintstagedrc
would be sufficient.
I've updated netlify configuration. |
@skitscha I've merged but the release script failed: https://github.com/okonet/react-scroll-sync/actions/runs/15084025131/job/42404345685 can you please take a look? It seems to be related to the pre-push hook you added. Maybe let's remove it? |
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull requests attempts to modernize the library by doing the following things:
I expanded upon this PR.
Closes #102