Skip to content

feat: converting to use typescript, functional components and upgrading to eslint 9 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2025

Conversation

skitscha
Copy link
Contributor

@skitscha skitscha commented May 12, 2025

This pull requests attempts to modernize the library by doing the following things:

  1. Upgrading to use functional components
  2. Upgrading to new eslint 9 cofiguration
  3. Upgrading to use typescript.
  4. Updating to allow use of react 19 which should address Update to react 19 support #102

I expanded upon this PR.

Closes #102

@skitscha
Copy link
Contributor Author

skitscha commented May 12, 2025

@okonet Can you update the netlify build to run build:storybook and to publish the public directory? I believe that should fix the deploy. I converted your style guide documentation into storybook documentation. Let me know if there are any other changes that you would like me to make. I believe this might be a breaking change since we won't require the type package anymore @types.

Copy link
Owner

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this. I think it's a good first step to modernize the library! Very much appreciated.

Comment on lines +1 to +3
export default {
"*": (filenames) => [`eslint ${filenames.join(" ")} --fix`, "git add"],
};
Copy link
Owner

@okonet okonet May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git add command isn't needed and I also think this can be simplified further but that's fine for now.

I think just this:

Suggested change
export default {
"*": (filenames) => [`eslint ${filenames.join(" ")} --fix`, "git add"],
};
{
"*": "eslint --fix",
};

as a .lintstagedrc would be sufficient.

@okonet
Copy link
Owner

okonet commented May 17, 2025

I've updated netlify configuration.

@okonet okonet merged commit 501ce1a into okonet:master May 17, 2025
0 of 4 checks passed
@okonet
Copy link
Owner

okonet commented May 17, 2025

@skitscha I've merged but the release script failed: https://github.com/okonet/react-scroll-sync/actions/runs/15084025131/job/42404345685 can you please take a look? It seems to be related to the pre-push hook you added. Maybe let's remove it?

Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to react 19 support
2 participants