fix(gen2): [External] Fix warning icon height in Callout#3822
Open
alexchen-okta wants to merge 2 commits into
Open
fix(gen2): [External] Fix warning icon height in Callout#3822alexchen-okta wants to merge 2 commits into
alexchen-okta wants to merge 2 commits into
Conversation
alexchen-okta
requested review from
glenfannin-okta,
jaredperreault-okta,
leemchale-okta,
lesterchoi-okta,
robertdamphousse-okta,
shawyu-okta,
shuowu-okta,
trevoring-okta and
vijetmahabaleshwar-okta
as code owners
April 16, 2025 16:27
alexchen-okta
force-pushed
the
ac-external-pr-3801
branch
from
April 16, 2025 16:28
b79ff7e to
8dd0eb1
Compare
alexchen-okta
changed the title
alexchen-okta
changed the title
| visibility: visible; | ||
| content: ''; | ||
| height: 102%; | ||
| height: calc(100% + 2px); |
Contributor
There was a problem hiding this comment.
For IE11, can you check this against the "Known issues" tab?
Contributor
Author
There was a problem hiding this comment.
Good catch, one of the known issues is that "IE11 is reported to not support calc() correctly in generated content"
Contributor
Author
|
Closing due to IE11 compatibility concerns. One of the known issues reported by https://caniuse.com/calc is "IE11 is reported to not support calc() correctly in generated content" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Original PR from external contributor: #3801
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: