Skip to content

Fix alignment value for Aligned512M. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

tobz
Copy link
Contributor

@tobz tobz commented Oct 25, 2020

Simple update to the alignment parameter for the generated Aligned512M struct.

Simple update to the alignment parameter for the generated `Aligned512M` struct.
@oliver-giersch
Copy link
Owner

Thanks for your contribution, I am a bit conflicting about what I want to do with the align utility, though. Apparently, there are some issues with using #[repr(align(X))] with values greater than the OS page size (when used with static values, I believe) and there was some talk about restricting values to 4K. I am not sure what has become of that, but I had been planning to remove all implementations above 4K for version 0.3.0, which I have had lying around for some time now.

Out of interest, do you have a particular use case for needing an alignment of 512M?

@tobz
Copy link
Contributor Author

tobz commented Oct 27, 2020 via email

@oliver-giersch
Copy link
Owner

From what I've read, the plans for alignment restrictions are canned for now, so I think I'm going to keep huge alignments for the 0.3.0 release and maybe mention the issues involving statics. Thanks for the fix!

@oliver-giersch oliver-giersch merged commit d67909c into oliver-giersch:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants