[BUGFIX] Fix findBySearchTermInBackendMode() with Postgres#977
Merged
Conversation
With Postgres, we cannot use `LIKE` for integer fields. Fixes #976
Coverage Report for CI Build 25181083397Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Fixes a Postgres-specific failure in FrontendUserRepository::findBySearchTermInBackendMode() by avoiding LIKE/string comparisons against the integer uid field.
Changes:
- Introduce a
SEARCH_FIELDSconstant to centralize the list of text fields searched viaLIKE. - Only add the
uidequality constraint when the search term is purely numeric (preventing Postgres integer-cast errors). - Add a changelog entry documenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Classes/Domain/Repository/FrontendUserRepository.php | Prevents invalid integer comparisons on Postgres by conditionally adding the uid matcher and refactoring LIKE matchers into a field list. |
| CHANGELOG.md | Documents the Postgres fix in the “Fixed” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AnReiter
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Postgres, we cannot use
LIKEfor integer fields.Fixes #976