`martian.cljs-http/bootstrap-openapi` sets incorrect `:api-root` value

[enspritz]

Using martian-cljs-http and martian-re-frame. Discovered this upgrading from martian 0.1.16 to 0.1.30.

(martian.re-frame/init "/rest/openapi.json")

fetches and parses the OpenAPI document, storing the result in re-frame's :db. Upon inspecting the re-frame :db, the :api-root value appears incorrect:

{:db
 {:martian.re-frame/martian
  {:martian.re-frame/default-id
   {:m
    {:api-root ":///rest/" ...

All subsequent attempts to use the REST API through martian fail, due to HTTP requests sent to the wrong URL, such as:

/wherever/the/calling/document/resides.html/%3a///rest/some-call

If %3a// is interpreted as an encoded URL, that would be ://, the same as in the erroneous :api-root value.

Skimming over the sources, martian.openapi/base-url looks of interest...

[enspritz]

Workaround: Judicious use of lambdaisland/uri to combine the browser window location with the OpenAPI JSON document URL:

(let [fully-qualified-url (lambdaisland.uri/join js/window.location.origin 
                                                 "/rest/openapi.json")]
  (martian.re-frame/init fully-qualified-url))

[oliyh]

Hi,

Thanks for your solution, it looks sensible. The value you see in martian looks like it's failed to read the scheme, port and host from the browser. I'll try to find time to have a look, tempted to just use your solution.

[enspritz]

The workaround might be a good defensive / backup / last-resort value. If only I had more time, I could dive into the logic of that function myself. Don't know the impact of modifying it..