`martian.schema/lookup-ref` does not decode slash in JSON Pointer

[gandalfthegraydelson]

Would like to first say that I love the library, great work.

I am generating an OpenAPI spec using reitit and malli.

One of the specs I am using is :time/local-date.

When it is referred to in a schema, it has "$ref": "#/components/schemas/time~1local-date", where the slash is encoded as ~1.

When I call martian-http/bootstrap-openapi, it fails with

clojure.lang.ExceptionInfo: Cannot find reference {:reference "#/components/schemas/time~1local-date"} (schema.cljc:89)

I have been using the following workaround in Martian in order to get this to work. The only difference is that I am calling decode-ref after splitting by slash.

(defn decode-ref [s] (string/replace s "~1" "/"))

(defn lookup-ref
  "Patch of `martian.schema/lookup-ref`. Calls `decode-ref` to convert ~1 to /"
  [ref ref-lookup]
  (if (string/starts-with? ref "#/")
    (or (get-in ref-lookup (drop 1 (map (comp keyword decode-ref) (string/split ref #"/"))))
        (throw (ex-info "Cannot find reference"
                        {:reference ref})))
    (throw (ex-info "Non-local references are not supported yet. References should start ref with '#/'"
                    {:reference ref}))))

[oliyh]

Hi,

Thanks for your kind words.

What nesting is used in the components - is localdate inside an object called time, or is it called time~1localdate? If the former then they simply don't match, I would probably attempt to fix the openapi json first as martian won't be the only tool that can't interpret it. If the latter, I'm surprised, because martian should only really care about splitting on /

[gandalfthegraydelson]

Thanks for the quick response. I should preface that I'm not super familiar with OpenAPI, but hopefully the below answers your question. It looks like the latter to me. Let me know if I can provide any more details.

It is defined as "time/local-date" in the components/schemas, like so

 "components": {
        "schemas": {
            "time/local-date": {
                "type": "string",
                "format": "date"
            },
        ...

And then here is an example of how it is referenced in paths

 "requestBody": {
                    "content": {
                        "application/json": {
                            "schema": {
                                "type": "object",
                                "properties": {
                                    "run-params": {
                                        "type": "object",
                                        "properties": {
                                            "from-date": {
                                                "$ref": "#/components/schemas/time~1local-date"
                                            },
                                            "to-date": {
                                                "$ref": "#/components/schemas/time~1local-date"
                                            }
                                        },
                                        "required": [
                                            "from-date",
                                            "to-date"
                                        ],
                                        "additionalProperties": false
                                    }
                                },
                                "required": [
                                    "run-params"
                                ],
                                "additionalProperties": false
                            }
                        }
                    }
                },