Skip to content

Update Cargo.toml #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Update Cargo.toml #2

merged 2 commits into from
Jan 15, 2025

Conversation

paulpr0
Copy link
Contributor

@paulpr0 paulpr0 commented Jan 15, 2025

Hi, thanks for building this - it looks useful so I thought I'd give it a try. I was on a slightly older version of rust on some machines, and got an error whilst building.

io_error_more seems to have been stabalised in 1.82. (rust-lang/rust#131396)

Compiling with 1.80 I get:

error[E0658]: use of unstable library feature 'io_error_more'
   --> C:\Users\paul\.cargo\registry\src\index.crates.io-6f17d22bba15001f\quicknotes-1.0.1\src/lib.rs:412:17
    |
412 |                 io::ErrorKind::IsADirectory,
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #86442 <https://github.com/rust-lang/rust/issues/86442> for more information

io_error_more seems to have been stabalised in 1.82. 

Compiling with 1.80 I get:

error[E0658]: use of unstable library feature 'io_error_more'
   --> C:\Users\paul\.cargo\registry\src\index.crates.io-6f17d22bba15001f\quicknotes-1.0.1\src/lib.rs:412:17
    |
412 |                 io::ErrorKind::IsADirectory,
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #86442 <rust-lang/rust#86442> for more information
@ollien
Copy link
Owner

ollien commented Jan 15, 2025

Thank you for spotting this!

Unless I'm mistaken, I think the MSRV would have to be rust 1.83 then; IsADirectory was stabilized then. Could you update this?

https://doc.rust-lang.org/std/io/enum.ErrorKind.html#variant.IsADirectory

Update rust-version to 1.83
@paulpr0
Copy link
Contributor Author

paulpr0 commented Jan 15, 2025

Good point. Done :-)

@ollien ollien merged commit e8dd53b into ollien:main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants