add --rename option to rename declarations and references #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--rename` option takes a string as input, treating every couple, separated by a space, as a find-replace option. For example, `--rename "$theService $myService "theFactory myFactory"`will replace `$theService` with `$myService` and `theFactory` with `myFactory` in both the declaration and in any annotation that will be added by ng-annotate. The actual use of the provider won't be changed. Also, a couple of JS grammar fixes here and there. Closes olov#44
|
Can you kindly redo the PR without any formatting changes? They make reviewing it much harder. Feel free to open up another PR for semicolon fixes later on, but not for removing trailing commas though because they are a feature, not a bug. |
|
Would you prefer if I update this PR or redo it entirely? |
|
Whichever you prefer - I just need a clean diff to look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--renameoption takes a string as input, treating every couple, separated by a space, as a find-replace option.For example,
--rename "$theService $myService "theFactory myFactory"will replace$theServicewith$myServiceandtheFactorywithmyFactoryin both the declaration and in any annotation that will be added by ng-annotate. The actual use of the provider won't be changed.Also, a couple of JS grammar fixes here and there.
Closes #44