Changes for 3GPP release 18 upgrade#694
Merged
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR upgrades AMF for a “Release 18” aligned dependency stack by migrating from github.com/omec-project/{openapi,nas,ngap} v1 to their v2 modules, updating generated API usage patterns, and adjusting multiple service/router handlers to the new v2 model shapes and helpers.
Changes:
- Migrate imports/types/constants to
openapi/v2,nas/v2, andngap/v2across core AMF, NGAP, NAS, consumer, producer, and callback paths. - Update HTTP handlers/callbacks to use v2 codec helpers (
openapi.Decode,openapi.SetBody) and v2 API client request-builder patterns. - Update generated router scaffolding (mt/location/eventexposure/communication) and add/adjust tests for several v2 migrations.
Reviewed changes
Copilot reviewed 98 out of 99 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| VERSION | Bumps project version to 3.0.0 |
| util/search_nf_service.go | Updates NF service URI selection to v2 models |
| util/init_context.go | Uses v2 deps; adds stable NF ID resolution; updates Mongo URL default |
| util/convert.go | Migrates NAS/OpenAPI model conversions to v2 getters/constants |
| service/init.go | Migrates openapi/nas/ngap/loggers to v2; updates service name/status constants |
| producer/subscription.go | Migrates AMF status subscription handling to v2 models/utils |
| producer/oam.go | Migrates OAM models/constants to v2; updates ProblemDetails handling |
| producer/oam_test.go | Updates tests for v2 model shapes (e.g., pointer fields) |
| producer/mt.go | Migrates MT producer logic to v2; updates ProblemDetails handling |
| producer/location_info.go | Migrates location producer logic to v2; updates ProvideLocInfo fields |
| producer/callback/subscription.go | Migrates AMF status notify callback to v2 client APIs/models |
| producer/callback/n1n2message.go | Migrates N1/N2 callbacks to v2 client APIs; sends multipart payloads |
| polling/nf_configuration.go | Updates nfConfigApi import to v2 |
| polling/nf_configuration_test.go | Updates nfConfigApi import to v2 |
| oam/api_registered_ue_context.go | Switches OAM HTTP encoding/ProblemDetails to v2 helpers |
| oam/api_purge_ue_context.go | Updates OAM purge endpoint to v2 models |
| ngap/util/ngap_util.go | Migrates NGAP imports to v2 |
| ngap/service/service.go | Migrates NGAP import to v2 |
| ngap/ngap_test.go | Updates tests for v2 model shapes (e.g., pointer fields) |
| ngap/message/send.go | Migrates NGAP/OpenAPI imports to v2; updates access-type constants |
| ngap/message/forward_ie.go | Migrates NGAP/OpenAPI imports to v2; adapts GUAMI/PLMN conversions |
| ngap/handler_test.go | Migrates ngapType import to v2 |
| ngap/dispatcher.go | Migrates NGAP imports to v2 |
| nfregistration/nf_registration.go | Migrates to v2 models; updates heartbeat/status patch values |
| nfregistration/nf_registration_test.go | Updates tests for v2 NFProfile pointer/timer fields |
| nas/nas_security/security.go | Migrates NAS/OpenAPI imports to v2; updates access-type constants |
| nas/handler.go | Migrates OpenAPI import to v2; updates access-type constants |
| nas/dispatch.go | Migrates NAS/OpenAPI imports to v2 |
| mt/routers.go | Replaces generated router wiring; adds canonicalization/wrappers; 501 defaults |
| mt/api_ue_reach_ind_document.go | Updates MT handler responses to 501 not implemented |
| mt/api_ue_contexts_collection.go | Adds new MT stub endpoint (enable-group-reachability) |
| mt/api_ue_contexts_collection_callbackreachability_notification.go | Adds MT callback stub route handler |
| mt/api_ue_context_document.go | Updates MT API handler serialization/error utilities to v2 |
| msgtypes/ngapmsgtypes/ngapmsgtypes.go | Migrates ngapType import to v2 |
| location/routers.go | Replaces generated router wiring; adds canonicalization/wrappers; 501 defaults |
| location/api_individual_ue_context_document.go | Updates location API handler serialization/error utilities to v2; adds stubs |
| location/api_individual_ue_context_document_callback_ue_location_notification.go | Adds location callback stub route handler |
| httpcallback/api_sm_context_status_notify.go | Updates callback decoding/encoding + ProblemDetails to v2 |
| httpcallback/api_nf_subscribe_notify.go | Updates callback decoding/encoding + ProblemDetails to v2 |
| httpcallback/api_n1_message_notify.go | Updates callback decoding/encoding + ProblemDetails to v2 |
| httpcallback/api_dereg_notify.go | Updates callback decoding/encoding + ProblemDetails to v2 |
| httpcallback/api_am_policy_control_update_notify.go | Updates callback decoding/encoding + ProblemDetails to v2 |
| gmm/sm.go | Migrates NAS/OpenAPI imports to v2; updates access-type constants |
| gmm/message/send.go | Migrates NAS/NGAP/OpenAPI imports to v2; updates access-type constants |
| gmm/message/build.go | Migrates NAS/OpenAPI imports to v2; adds ExtractAv5gAka helper; adapts auth types |
| eventexposure/routers.go | Replaces generated router wiring; adds canonicalization/wrappers; 501 defaults |
| eventexposure/api_subscriptions_collection_document.go | Updates event exposure handler decoding/encoding + ProblemDetails to v2 |
| eventexposure/api_subscriptions_collection_collection_callback_subscription_id_change_evt_report.go | Adds event exposure callback stub handler |
| eventexposure/api_subscriptions_collection_collection_callback_event_report.go | Adds event exposure callback stub handler |
| eventexposure/api_individual_subscription_document.go | Updates event exposure handlers decoding/encoding + ProblemDetails to v2 |
| context/sm_context.go | Migrates NAS/OpenAPI imports to v2; updates SMF profile type |
| context/ran_ue.go | Migrates NGAP/OpenAPI imports to v2; adapts model constructors/pointer fields |
| context/db.go | Migrates OpenAPI import to v2; updates access-type constants |
| context/context.go | Migrates OpenAPI/nfConfigApi imports to v2; adapts NF service model fields |
| context/context_test.go | Updates tests for v2 model shapes (pointer fields / PLMN types) |
| context/common_function.go | Migrates OpenAPI import to v2 |
| context/amf_ran.go | Migrates NGAP/OpenAPI imports to v2; adapts PLMN/GNB model setters/getters |
| context/3gpp_types.go | Migrates OpenAPI import to v2 |
| consumer/ue_context_management.go | Migrates Nudm UECM client usage to v2 request-builder pattern |
| consumer/ue_authentication.go | Migrates Nausf client usage to v2 request-builder pattern; refactors PLMN selection |
| consumer/ue_authentication_test.go | Adds unit tests for serving-network PLMN selection helper |
| consumer/sm_context_test.go | Adds multipart request/response tests for SM context update handling |
| consumer/nsselection.go | Migrates Nnssf client usage to v2 request-builder pattern; adapts slice info models |
| consumer/nf_management.go | Migrates NRF management client usage to v2 request-builder pattern; updates NFProfile type |
| consumer/nf_discovery.go | Migrates NRF discovery client usage to v2 request-builder pattern; updates subscription model |
| consumer/communication.go | Migrates Namf Communication client usage to v2; adapts UE context model fields |
| consumer/am_policy.go | Migrates PCF AM policy control client usage to v2 request-builder pattern |
| communication/api_subscriptions_collection_document.go | Updates communication handlers decoding/encoding + ProblemDetails to v2 |
| communication/api_subscriptions_collection_collection_callback_amf_status_change.go | Adds communication callback stub handler |
| communication/api_non_uen2_messages_subscriptions_collection_document.go | Updates non-UE N2 subscription handler responses to 501 not implemented |
| communication/api_non_uen2_messages_subscriptions_collection_collection_callback_n2_info_notify.go | Adds non-UE N2 notify callback stub handler |
| communication/api_non_uen2_messages_collection_document.go | Updates non-UE N2 transfer handler responses to 501 not implemented |
| communication/api_non_uen2_message_notification_individual_subscription_document.go | Updates non-UE N2 unsubscribe handler responses to 501 not implemented |
| communication/api_n1_n2_subscriptions_collection_for_individual_ue_contexts_document.go | Updates N1N2 subscribe handler decoding/encoding + ProblemDetails to v2 |
| communication/api_n1_n2_subscriptions_collection_for_individual_ue_contexts_collection_callback_n1_n2_message_notifyn2_notify_callback_uri.go | Adds N2 callback stub handler |
| communication/api_n1_n2_subscriptions_collection_for_individual_ue_contexts_collection_callback_n1_n2_message_notifyn1_notify_callback_uri.go | Adds N1 callback stub handler |
| communication/api_n1_n2_message_collection_document.go | Updates N1N2 transfer handler decoding/encoding + ProblemDetails to v2 |
| communication/api_n1_n2_message_collection_collection_callback_n1_n2_transfer_failure.go | Adds N1N2 transfer-failure callback stub handler |
| communication/api_n1_n2_individual_subscription_document.go | Updates N1N2 unsubscribe handler encoding + ProblemDetails to v2 |
| communication/api_individual_ue_context_document_callback_n2_message_notify.go | Adds N2 message notify callback stub handler |
| communication/api_individual_subscription_document.go | Updates AMF status subscription modify/unsubscribe handlers to v2 |
| communication/api_individual_subscription_document_callback_on_amf_status_change.go | Adds AMF status change callback stub handler |
| .github/dependabot.yml | Enables Go module dependency updates via Dependabot |
| go.mod | Bumps omec-project deps to v2 modules; adjusts indirect deps |
| go.sum | Updates checksums for v2 module graph |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
andybavier
reviewed
May 11, 2026
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
andybavier
reviewed
May 14, 2026
andybavier
reviewed
May 14, 2026
andybavier
reviewed
May 14, 2026
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.