Skip to content

Make changes to avoid duplicate AllowedSnssai#703

Merged
gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:de-duplicate-snssai
May 15, 2026
Merged

Make changes to avoid duplicate AllowedSnssai#703
gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:de-duplicate-snssai

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR avoids duplicate Allowed NSSAI entries when deriving NGAP/NAS AllowedNssai data, and adds regression tests for the deduplication behavior.

Changes:

  • Adds a shared NGAP AllowedNSSAI builder that deduplicates S-NSSAIs and enforces the NGAP maximum of 8 items.
  • Updates Initial Context Setup, Handover Request, and Path Switch Request Acknowledge to use UE-specific allowed NSSAI data.
  • Adds GMM logic/tests to rebuild requested NSSAI without retaining duplicates.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
ngap/message/build.go Adds deduplicating AllowedNSSAI construction and uses it in NGAP message builders.
ngap/message/build_test.go Adds tests for NGAP AllowedNSSAI deduplication, max size enforcement, and UE-specific NSSAI usage.
gmm/handler.go Refactors requested NSSAI handling into a helper that rebuilds allowed NSSAI without duplicates.
gmm/requested_nssai_test.go Adds a regression test for requested NSSAI deduplication.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gab-arrobo
gab-arrobo merged commit 1553ac3 into omec-project:main May 15, 2026
12 checks passed
@gab-arrobo
gab-arrobo deleted the de-duplicate-snssai branch May 15, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants