Make changes to avoid duplicate AllowedSnssai#703
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR avoids duplicate Allowed NSSAI entries when deriving NGAP/NAS AllowedNssai data, and adds regression tests for the deduplication behavior.
Changes:
- Adds a shared NGAP AllowedNSSAI builder that deduplicates S-NSSAIs and enforces the NGAP maximum of 8 items.
- Updates Initial Context Setup, Handover Request, and Path Switch Request Acknowledge to use UE-specific allowed NSSAI data.
- Adds GMM logic/tests to rebuild requested NSSAI without retaining duplicates.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ngap/message/build.go |
Adds deduplicating AllowedNSSAI construction and uses it in NGAP message builders. |
ngap/message/build_test.go |
Adds tests for NGAP AllowedNSSAI deduplication, max size enforcement, and UE-specific NSSAI usage. |
gmm/handler.go |
Refactors requested NSSAI handling into a helper that rebuilds allowed NSSAI without duplicates. |
gmm/requested_nssai_test.go |
Adds a regression test for requested NSSAI deduplication. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmaciocco
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.