Skip to content

Use ApplyLogSetting function to simplify log setting#717

Merged
gab-arrobo merged 2 commits into
omec-project:mainfrom
gab-arrobo:use-ApplyLogSetting
Jun 12, 2026
Merged

Use ApplyLogSetting function to simplify log setting#717
gab-arrobo merged 2 commits into
omec-project:mainfrom
gab-arrobo:use-ApplyLogSetting

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors AMF log-level initialization to delegate per-component log configuration to util/logger.ApplyLogSetting, reducing repeated parsing/validation logic and aligning AMF log setup with the shared util logger behavior.

Changes:

  • Simplified AMF.setLogLevel() by replacing duplicated per-logger level parsing with utilLogger.ApplyLogSetting(...).
  • Removed the now-unneeded zapcore import from service/init.go.
  • Bumped github.com/omec-project/util dependency from v1.7.3 to v1.7.4 to pick up ApplyLogSetting.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
service/init.go Replaces inline log-level parsing with utilLogger.ApplyLogSetting calls for AMF/NAS/NGAP/OpenApi/Util loggers.
go.mod Updates github.com/omec-project/util to v1.7.4.
go.sum Updates checksums for github.com/omec-project/util v1.7.4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo
gab-arrobo merged commit 85ee738 into omec-project:main Jun 12, 2026
12 checks passed
@gab-arrobo
gab-arrobo deleted the use-ApplyLogSetting branch June 12, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants