Reformatted specs and reworked way to propagate InvalidCredentials error to application #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reformatted specs so they have unified style now and they are a bit easier to support.
Also I added check which enforces non-empty passwords which is already mentioned in tickets many times. For example #15, #18
Also instead of raising custom extension
OmniAuth::Strategies:: LDAP::MissingCredentialsError
I used methodfail!(:missing_credentials)
which is recommended way to propagate errors from OmniAuth to application. Otherwise non-Rails rack based app can not handle exceptions raised from middleware