Skip to content

Faraday Timeout Exception not caught #43

Closed
@sriedel

Description

@sriedel

When using Faraday with the Net::HTTP adapter, it transforms a Timeout::Error into a Faraday::Error::TimeoutError exception (see https://github.com/lostisland/faraday/blob/master/lib/faraday/adapter/net_http.rb#L51).

However https://github.com/intridea/omniauth-oauth2/blob/master/lib/omniauth/strategies/oauth2.rb#L83 only catches a Timeout::Error; you'll probably want to catch the Faraday::Error::TimeoutError there as well. From what I can see, oauth2 doesn't touch faraday exceptions, so it won't be transformed back.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions