Use BIGSERIAL for auto incremental default IDs.

[johngian]

No description provided.

[johngian]

This patch is something we use in our production imposm3-based OSM import pipeline. The tables storing relation members reached the limit of max integer used for SERIAL. In case this is an overhead we don't want (int vs bigint) we can make it configurable.

For more information: https://phabricator.wikimedia.org/T389462

[elukey]

Error that we got in Postgres:

nextval: reached maximum value of sequence "wikidata_relation_members_id_seq" (2147483647)

Table specs:

gis=# \d public.wikidata_relation_members
                                     Table "public.wikidata_relation_members"
  Column  |          Type           | Collation | Nullable |                        Default                        
----------+-------------------------+-----------+----------+-------------------------------------------------------
 id       | integer                 |           | not null | nextval('wikidata_relation_members_id_seq'::regclass)
 osm_id   | bigint                  |           | not null | 
 wikidata | character varying       |           |          | 
 geometry | geometry(Geometry,3857) |           |          | 
Indexes:
    "wikidata_relation_members_pkey" PRIMARY KEY, btree (osm_id, id)
    "wikidata_relation_members_geom" gist (geometry)
    "wikidata_relation_members_idx" btree (wikidata)

[olt]

Relation members are a special case, as all members are re-inserted when the relation or any relation member is changed.
I can see how you could hit that limit with a generic mapping like wikidata over a longer period.

The following should give you an idea if other tables are reaching this limit as well:

select schemaname as schema, 
       sequencename as sequence, 
       last_value
from pg_sequences;

I estimate a storage overhead of 1-2% when changing all IDs from SERIAL to BIGSERIAL for a "standard" OSM database used for rendering. I'm fine with this, as it makes it ready for even not-so-edge-case imports in the longer future.