Skip to content

Fix Unsupported feature returns #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Unsupported feature returns #2543

wants to merge 1 commit into from

Conversation

isaacault
Copy link
Contributor

  • urKernelCreateWithNativeHandle handle param is [nocheck]. Remove invalid handle as reason to return unsupported feature.
  • Mark urKernelGetNativeHandle handle param as [nocheck]. Remove invalid handle as reason to return unsupported feature.

@isaacault
Fix Unsupported feature returns
299f3a1 
* urKernelCreateWithNativeHandle handle param is [nocheck]. Remove
  invalid handle as reason to return unsupported feature.
* Mark urKernelGetNativeHandle handle param as [nocheck]. Remove invalid
  handle as reason to return unsupported feature.
@isaacault isaacault requested a review from a team as a code owner January 10, 2025 04:20
@github-actions github-actions bot added loader Loader related feature/bug specification Changes or additions to the specification labels Jan 10, 2025
@isaacault
Copy link
Contributor Author

UNSUPPORTED_FEATURE is a valid return for when the adapter does not have a notion of "native handles". As for the lack of support for UR_ERROR_INVALID_KERNEL, this can be addressed at a later date and is logged by #2555.

@isaacault isaacault closed this Jan 15, 2025
@isaacault isaacault deleted the kernel-spec branch January 15, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
loader Loader related feature/bug specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isaacault