Skip to content

Enable support for months and years #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

amotl
Copy link

@amotl amotl commented Nov 18, 2021

Dear Sergey,

first things first: Thanks a stack for what looks like you have been taking over maintenance for this fine package from @wroberts and giving it some love. Cheers!

We are very happy that you listened to the needs of the community and integrated ef62cf1 and 0a71785 already. In the same spirit, we would like to submit a patch which is also of interest to other people and humbly ask for your kindness to integrate it into the code base.

We are aware that this topic has been discussed at wroberts#7 and wroberts#13 already. While the original author was not keen to support it [1], we built upon wroberts#10 by @duramato, submitted wroberts#26 once more [2] and, at the same time, would like to add some energy by sending it to you as well.

With kind regards,
Andreas.

[1]

@wroberts: Months and years are periods of time directly related to the calendar; they could be included in pytimeparse, but only relative to a particular date (such as the current system time). There's also complications such as leap-years and leap-seconds. For the moment, I chose to only include time expressions which correspond to a fixed length of time.

-- wroberts#7 (comment)

[2]

@amotl: I still believe it would be reasonable to assume "30 days for a month" and "365 days for a year" as the basis for calculations with those units. I agree that this approximation should be documented well.

-- wroberts#26 (comment)

/cc @jd, @duramato, @martinb3, @jaraco, @jpopelka, @jhtitor, @Toldry, @hozn.

@onegreyonewhite
Copy link
Owner

Thanks for the suggested fixes. I'll look it on Monday and maybe release new version.

I think you add good comment to README which enough for understanding about years and months parameters.

@onegreyonewhite
Copy link
Owner

@amotl thanx for your good contributions! 1.4.0 with this changes released.

@amotl
Copy link
Author

amotl commented Nov 25, 2021

Thank you very much, I just converged this into grafana-toolbox/grafanimate#14 - excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants