-
Notifications
You must be signed in to change notification settings - Fork 210
Closed
Description
Hi, while updating to 1.6.0, I found couple of type issues.
- It might be worth using popoverDirection: "up" | "down" instead of enums.
Why?
- Use | instead of & in Configs['shortcuts']
shortcuts?: {
today?: string;
yesterday?: string;
past?: (period: number) => string;
currentMonth?: string;
pastMonth?: string;
} | { // <----- change here
[key: string]: ShortcutsItem;
};This avoids type override, ie, typescript will not combine types today into string.
Why?
I will submit a PR shortly.
Swapnull
Metadata
Metadata
Assignees
Labels
No labels

