Skip to content

[Bug] Gap in range due to off-by-one fixed px value #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AbhinavRobinson opened this issue Jul 3, 2023 · 1 comment
Closed

[Bug] Gap in range due to off-by-one fixed px value #158

AbhinavRobinson opened this issue Jul 3, 2023 · 1 comment

Comments

@AbhinavRobinson
Copy link
Contributor

AbhinavRobinson commented Jul 3, 2023 •
edited
Loading

https://github.com/onesine/react-tailwindcss-datepicker/blob/9c4716b696efdd2a5c23071f4b5a8a8aa02d5107/src/components/Calendar/index.tsx#L245C3-L245C3

Causes slight gap in range which is 297px, should be 296px.
Screenshot 2023-07-03 at 6 19 33 PM

After fix (changing value to 296px)

Screenshot 2023-07-03 at 6 19 59 PM
AbhinavRobinson added a commit to AbhinavRobinson/react-tailwindcss-datepicker that referenced this issue Jul 3, 2023
@AbhinavRobinson
fix: off by one error onesine#158
3861dcb
@AbhinavRobinson AbhinavRobinson mentioned this issue Jul 3, 2023
Merged
@AbhinavRobinson
Copy link
Contributor Author

Fixed in PR above (#159)

onesine added a commit that referenced this issue Jul 3, 2023
@onesine
Merge pull request #159 from AbhinavRobinson/master
8ef115a 
fix: off by one error #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AbhinavRobinson