Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Conversation

@badosu
Copy link
Collaborator

@badosu badosu commented May 28, 2018

This is quick hack to fix this glaring issue.

screenshot from 2018-05-28 11-40-02

The colors used here are taken from https://github.com/badosu/oni/blob/72157777d8cf711658c695989982e5a8e561a0cd/browser/src/Services/Language/LanguageClientStatusBar.tsx#L87-L88

There are some better approaches that can be made, but require some discussion before proceeding.

  • Use a general higher order component for status bar items that shares the same style
  • Allow each status line component to define it's own style, but define or use a theme color
  • Continue as it is

Fixes #2157

@akinsho
Copy link
Member

akinsho commented May 31, 2018

@badosu how about potentially just removing the color entirely?, I was thinking that over time if you imagine oni has say 10 status item and they are all colored slightly differently or even the exact same but with a bit of padding between each the status bar wouldn't have the best appearance as opposed to vscode or atom all of which just have the text and an icon and some padding so things aren't too close together

@badosu
Copy link
Collaborator Author

badosu commented Jun 13, 2018

@akin909 Would that be the same as to define the color on the parent component of the statusbar items?

If so, I can try that, the issue with hardcoded color vs theming will persist though.

@akinsho
Copy link
Member

akinsho commented Jun 13, 2018

@badosu just tried a quick test and I think all you would need to do is remove the background-color from the prettier status item aka the one that has a class of prettier I know there are a few components in there and you get:

screen shot 2018-06-13 at 16 39 54

I think having no colors on the items makes for a cleaner aesthetic, which is easier to maintain aka no worrying about what colors to use etc. plus less distracting

@akinsho
Copy link
Member

akinsho commented Jun 30, 2018

@badosu I've actually removed the background color from the plugin so this should resolve the issue this PR was aimed at let me know if the results work for you re. #2157

@badosu badosu closed this Jul 1, 2018
@badosu
Copy link
Collaborator Author

badosu commented Jul 1, 2018

Thanks @akin, I am still not sure if it works for my theme as I said the foreground gets blue on the foreground. I'll test and get back later.

@badosu badosu deleted the amadeus/adjust-prettier-plugin-color branch July 1, 2018 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prettier plugin statusline item highlighted weirdly

2 participants