Skip to content

Implement is_floating_point on dtypes #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Conversation

justinchuby
Copy link
Member

Migration of changes in microsoft/onnxscript#2335

Migration of changes in microsoft/onnxscript#2335

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby requested review from titaiwangms and a team as code owners May 28, 2025 16:02
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (4e5b3fb) to head (1f43117).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onnx_ir/_enums.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   81.81%   81.80%   -0.01%     
==========================================
  Files          57       57              
  Lines        6966     6968       +2     
  Branches      953      953              
==========================================
+ Hits         5699     5700       +1     
- Misses        901      902       +1     
  Partials      366      366              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added this to the 0.1.0 milestone May 28, 2025
@justinchuby justinchuby merged commit 77fc946 into main May 28, 2025
23 checks passed
@justinchuby justinchuby deleted the justinchu/is-float branch May 28, 2025 17:17
@justinchuby justinchuby mentioned this pull request May 28, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants