Skip to content

Implement the all_values convenience function - #349

Draft
justinchuby wants to merge 1 commit into
mainfrom
justinchu/all_values
Draft

justinchuby wants to merge 1 commit into
mainfrom
justinchu/all_values

Conversation

@justinchuby

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@codecov

codecov Bot commented Feb 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.48%. Comparing base (c96b72b) to head (e44bffc).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/onnx_ir/_convenience/__init__.py 4.16% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   80.04%   80.48%   +0.43%     
==========================================
  Files          52       52              
  Lines        6395     6706     +311     
  Branches     1294     1389      +95     
==========================================
+ Hits         5119     5397     +278     
- Misses        912      943      +31     
- Partials      364      366       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yield value
for node in traversal.RecursiveGraphIterator(graph_like):
# NOTE: If an input or initializer of a subgraph is unused, it will not be yielded by this function since it is not technically part of the graph. This is consistent with ONNX's handling of unused inputs and initializers.
for value in node.inputs:

Check failure

Code scanning / lintrunner

MYPY/assignment Error

Incompatible types in assignment (expression has type "Value | None", variable has type "Value") To disable, use # type: ignore[assignment]
@justinchuby justinchuby added this to the 1.0.0 milestone May 21, 2026
@justinchuby justinchuby modified the milestones: 1.0.0, 1.1.0 Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants