[Pass] Support CSE constant nodes #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 74.51% 74.51%
=======================================
Files 37 38 +1
Lines 4595 4686 +91
Branches 933 957 +24
=======================================
+ Hits 3424 3492 +68
- Misses 826 841 +15
- Partials 345 353 +8 ☔ View full report in Codecov by Sentry. |
|
@justinchuby Not sure why I checked the sign off, but DCO still fails... |
titaiwangms
force-pushed
the
titaiwang/support_constant_cse
branch
from
84ad83b to
342add5
Compare
justinchuby
reviewed
Jun 18, 2025
justinchuby
reviewed
Jun 18, 2025
justinchuby
reviewed
Jun 18, 2025
|
Very nice, thanks! |
|
@titaiwangms maybe ensure that the email you signoff with matches the github account you use? |
Signed-off-by: Ti-Tai Wang <[email protected]>
Signed-off-by: Ti-Tai Wang <[email protected]>
Co-authored-by: Justin Chu <[email protected]> Signed-off-by: Ti-Tai Wang <[email protected]>
Signed-off-by: Ti-Tai Wang <[email protected]>
titaiwangms
force-pushed
the
titaiwang/support_constant_cse
branch
from
c626f55 to
7f853a8
Compare
justinchuby
approved these changes
Jun 18, 2025
Co-authored-by: Justin Chu <[email protected]> Signed-off-by: Ti-Tai Wang <[email protected]>
|
@gramalingam for another review |
Signed-off-by: Ti-Tai Wang <[email protected]>
gramalingam
reviewed
Jun 19, 2025
gramalingam
reviewed
Jun 19, 2025
gramalingam
reviewed
Jun 19, 2025
src/onnx_ir/passes/common/common_subexpression_elimination_test.py
Outdated
Show resolved
Hide resolved
gramalingam
approved these changes
Jun 19, 2025
Signed-off-by: Ti-Tai Wang <[email protected]>
justinchuby
reviewed
Jun 20, 2025
Comment on lines
+73
to
+81
| value = v.value | ||
| if v.type in ( | ||
| ir.AttributeType.INTS, | ||
| ir.AttributeType.FLOATS, | ||
| ir.AttributeType.STRINGS, | ||
| ): | ||
| # For INT, FLOAT and STRING attributes, we convert them to tuples | ||
| # to ensure they are hashable. | ||
| value = tuple(value) |
There was a problem hiding this comment.
I think this can be improved: value_ints is the same as 1d tensor value int64. Maybe leverage the new
ir-py/src/onnx_ir/_convenience/__init__.py
Line 400 in e211825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the constant is smaller than size limit, it's csed.
Use tobytes to hash TENSOR when it's smaller than size_limit (parameter of the pass).