Skip to content

feat: onnx wheel for linux, experimental support for 3.13t (free threading) #6621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 109 commits into from

Conversation

andife
Copy link
Member

@andife andife commented Jan 5, 2025

Description

First try python 3.13t

release_pipelines
[X] Win (problems with dependency nbval, ipython, jupyter_client)
[ ] linux aarch
[ ] linux x86
[X] mac

@andife andife requested a review from a team as a code owner January 5, 2025 09:06
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (97a7fd9) to head (e0eac31).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6621   +/-   ##
=======================================
  Coverage   56.45%   56.45%           
=======================================
  Files         509      509           
  Lines       32515    32515           
  Branches     3057     3057           
=======================================
  Hits        18356    18356           
  Misses      13334    13334           
  Partials      825      825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andife
Copy link
Member Author

andife commented Jan 5, 2025

We probably have to wait for python-cffi/cffi#126

@andife andife added the run release CIs Use this label to trigger release tests in CI label Jan 5, 2025
@andife andife temporarily deployed to testpypi_onnxweekly January 5, 2025 14:20 — with GitHub Actions Inactive
@andife andife changed the title Update main.yml First try python 3.13t First try python 3.13t Jan 6, 2025
@justinchuby
Copy link
Member

Looks promising!

@justinchuby
Copy link
Member

I will create a PR to fix the tests

@justinchuby
Copy link
Member

#6631

@justinchuby justinchuby added this to the 1.18 milestone Jan 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
Remove the use of struct and leverage ml_dtypes to clean up helper
tests. This should unblock #6621

---------

Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Copy link
Member

Looks like the error is actually in from array

@justinchuby
Copy link
Member

#6604

@justinchuby
Copy link
Member

Test errors are resolved

@andife andife changed the title First try python 3.13t onnx wheel, 3.13t (free threading) Jan 16, 2025
@andife andife modified the milestones: 1.18, 1.19 Jan 18, 2025
@andife
Copy link
Member Author

andife commented Jan 23, 2025

We can currently also say that we are only integrating the mac build into our regular repo for the time being and can thus make the mac 3.13t build available on a weekly basis

@justinchuby

@justinchuby
Copy link
Member

Sure that works. Is using the workflow from quantsightlabs a viable solution from a supply chain perspective?

@justinchuby
Copy link
Member

Maybe we can use it only for 3.13t for now.

@andife andife changed the title onnx wheel, 3.13t (free threading) onnx wheel, experimental support for 3.13t (free threading) Jan 25, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Jan 25, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Mar 5, 2025
Signed-off-by: Andreas Fehlner <[email protected]>
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Mar 5, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Mar 6, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Mar 6, 2025
andife added 2 commits March 6, 2025 08:23
Signed-off-by: Andreas Fehlner <[email protected]>
Signed-off-by: Andreas Fehlner <[email protected]>
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Mar 6, 2025
Signed-off-by: Andreas Fehlner <[email protected]>
@andife andife removed the run release CIs Use this label to trigger release tests in CI label Mar 6, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2025
### Description
build experimental mac freethreading wheels for publishing at pypi and
test.pypi

### Motivation and Context
Integrate working parts of #6621

---------

Signed-off-by: Andreas Fehlner <[email protected]>
@andife andife changed the title onnx wheel, experimental support for 3.13t (free threading) onnx wheel for linux, experimental support for 3.13t (free threading) Mar 7, 2025
@andife andife changed the title onnx wheel for linux, experimental support for 3.13t (free threading) feat: onnx wheel for linux, experimental support for 3.13t (free threading) Mar 7, 2025
@andife
Copy link
Member Author

andife commented Mar 10, 2025

I will create a new PR for the linux variant

@andife andife closed this Mar 10, 2025
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in PR Tracker Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome do not merge topic: build Issues related to ONNX builds and packages
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants