vet optional description args in assertions, fixing #560 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

onsi merged 1 commit into onsi:master from thediveo:issue-560-vet-extra-matchers

Jul 25, 2022

Collaborator

thediveo commented Jul 25, 2022 •

edited

Loading

panics when it detects a Gomega Matcher in the first position of optional description args.
accepts Gomega Matchers as part of an optional description when in other positions as args to the formatted first description arg.
comes with unit tests.


          vet optional description args in assertions, fixing onsi#560

d3c675a

Owner

onsi commented Jul 25, 2022

looks great!!

onsi merged commit 8e37808 into onsi:master

thediveo deleted the issue-560-vet-extra-matchers branch

July 26, 2022 05:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet