-
Notifications
You must be signed in to change notification settings - Fork 30
2024 refactor part 3/3: cleanup #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
872ec30
to
db91e6d
Compare
Closed
bassosimone
reviewed
Feb 5, 2024
bassosimone
reviewed
Feb 5, 2024
bassosimone
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am mostly okay with all these changes; I asked questions when unsure!
This commit should be reverted prior to merge (see 🔄 emoji 🙃)
Co-authored-by: Simone Basso <[email protected]>
0cdde89
to
145e088
Compare
Co-authored-by: Simone Basso <[email protected]>
…2024-refactor_cleanup * '2024-refactor_cleanup' of github.com:ooni/backend: Update README.md
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3/3
As part of this PR, everything that is dead code, is removed from the source tree.
This includes:
af/
-> this was the old airflow postgresql related codeold_backend/
-> this was the super old pre-2016 twisted based backenddocs/
-> contained documentation about the ~2016 data pipelineReadme.md
-> Still talks about some super old stuffrate_limit_quotas.py
-> duplicate of file inside ooniapi/rate_limit_quotas.pyooniapi/scripts
-> these scripts expect a postgresql database, which doesn't exist anymoreapi/refresh_deps
-> non-existent files are referenced in itmarkdown/*
-> these docs are not used anywhere and are superseeded by the swagger based docsSuperseeds:
#797
#798
#791