Refactor Retrievers #1138
Merged
Refactor Retrievers #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: letonghan <[email protected]>
letonghan
requested review from
lkk12014402,
lvliang-intel,
ftian1 and
chensuyue
as code owners
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
1 task
|
Related PR to fix GenAIExamples issues: opea-project/GenAIExamples#1387 |
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
…o refactor_retrievers
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
…/GenAIComps into refactor_retrievers
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
…o refactor_retrievers
for more information, see https://pre-commit.ci
Signed-off-by: letonghan <[email protected]>
|
@letonghan neo4j yaml is still missing in docker_compose folder |
|
@letonghan the retriever_neo4j test passed but seems the telemetry traces endpoint 4318 didn't connect: https://github.com/opea-project/GenAIComps/actions/runs/12788252024/job/35649181305?pr=1138#step:4:4037 |
Signed-off-by: letonghan <[email protected]>
…o refactor_retrievers
for more information, see https://pre-commit.ci
Thanks @rbrugaro, the missing docker compose yaml files are added now. |
|
|
chensuyue
pushed a commit
to opea-project/GenAIExamples
that referenced
this pull request
Jan 16, 2025
Delete redundant retrievers docker image in docker_images_list.md. Refactor Retrievers related Examples READMEs. Change all of the comps/retrievers/xxx/xxx/Dockerfile path into comps/retrievers/src/Dockerfile. Fix the Examples CI issues of PR opea-project/GenAIComps#1138. Signed-off-by: letonghan <[email protected]>
smguggen
pushed a commit
to opea-aws-proserve/GenAIComps
that referenced
this pull request
Jan 23, 2025
Refactor retrievers into E-RAG style.
The folder structure after refactored is as below:
- retrievers
- deployment
- docker_compose
- kubernetes
- src
- integrations
- redis.py
- milvus.py
- ...
- Dockerfile
- opea_retrievers_microservice.py
- README.md
- requirements.txt
- set_env.sh
opea-project#1004
Signed-off-by: letonghan <[email protected]>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Mar 4, 2025
Delete redundant retrievers docker image in docker_images_list.md. Refactor Retrievers related Examples READMEs. Change all of the comps/retrievers/xxx/xxx/Dockerfile path into comps/retrievers/src/Dockerfile. Fix the Examples CI issues of PR opea-project/GenAIComps#1138. Signed-off-by: letonghan <[email protected]> Signed-off-by: Chingis Yundunov <[email protected]>
madison-evans
pushed a commit
to SAPD-Intel/GenAIComps
that referenced
this pull request
May 12, 2025
Refactor retrievers into E-RAG style.
The folder structure after refactored is as below:
- retrievers
- deployment
- docker_compose
- kubernetes
- src
- integrations
- redis.py
- milvus.py
- ...
- Dockerfile
- opea_retrievers_microservice.py
- README.md
- requirements.txt
- set_env.sh
opea-project#1004
Signed-off-by: letonghan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor retrievers into E-RAG style.
The folder structure after refactored is as below:
Issues
#1004
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
In
requirements.txtTests
Local tested