Revert wrong handling of stream #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spycsh
requested review from
lvliang-intel,
ftian1,
letonghan and
XinyaoWa
as code owners
letonghan
approved these changes
Mar 3, 2025
4 tasks
Codecov ReportAttention: Patch coverage is
|
chensuyue
approved these changes
Mar 3, 2025
8 tasks
chensuyue
pushed a commit
to opea-project/GenAIExamples
that referenced
this pull request
Mar 3, 2025
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Mar 4, 2025
align with opea-project/GenAIComps#1354 Signed-off-by: Chingis Yundunov <[email protected]>
dtrawins
pushed a commit
to dtrawins/GenAIComps
that referenced
this pull request
Mar 5, 2025
opea-project#1300 (comment) Signed-off-by: Spycsh <[email protected]> Signed-off-by: Dariusz Trawinski <[email protected]>
intelsharath
pushed a commit
to intelsharath/GenAIComps
that referenced
this pull request
Mar 5, 2025
opea-project#1300 (comment) Signed-off-by: Spycsh <[email protected]> Signed-off-by: Raghava, Sharath <[email protected]>
dtrawins
pushed a commit
to dtrawins/GenAIComps
that referenced
this pull request
Mar 8, 2025
opea-project#1300 (comment) Signed-off-by: Spycsh <[email protected]> Signed-off-by: Dariusz Trawinski <[email protected]>
dtrawins
pushed a commit
to dtrawins/GenAIComps
that referenced
this pull request
Mar 8, 2025
Signed-off-by: Spycsh <[email protected]>
dtrawins
pushed a commit
to dtrawins/GenAIComps
that referenced
this pull request
Mar 8, 2025
opea-project#1300 (comment) Signed-off-by: Spycsh <[email protected]> Signed-off-by: Dariusz Trawinski <[email protected]>
dtrawins
pushed a commit
to dtrawins/GenAIComps
that referenced
this pull request
Mar 8, 2025
Signed-off-by: Spycsh <[email protected]> Signed-off-by: Dariusz Trawinski <[email protected]>
jedwards-habana
pushed a commit
to jedwards-habana/GenAIExamples
that referenced
this pull request
Mar 11, 2025
align with opea-project/GenAIComps#1354 Signed-off-by: Edwards, James A <[email protected]>
cwlacewe
pushed a commit
to cwlacewe/GenAIComps
that referenced
this pull request
Mar 19, 2025
opea-project#1300 (comment) Signed-off-by: Spycsh <[email protected]> Signed-off-by: Lacewell, Chaunte W <[email protected]>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Mar 21, 2025
align with opea-project/GenAIComps#1354 Signed-off-by: Chingis Yundunov <[email protected]>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Apr 1, 2025
align with opea-project/GenAIComps#1354 Signed-off-by: Chingis Yundunov <[email protected]>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Apr 1, 2025
align with opea-project/GenAIComps#1354 Signed-off-by: Chingis Yundunov <[email protected]>
madison-evans
pushed a commit
to SAPD-Intel/GenAIComps
that referenced
this pull request
May 12, 2025
opea-project#1300 (comment) Signed-off-by: Spycsh <[email protected]>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
May 16, 2025
align with opea-project/GenAIComps#1354 Signed-off-by: Chingis Yundunov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert wrong handling of stream.
There are some reports on ChatQnA and other examples that show the streaming connection was closed before returning any concrete content. In vLLM log it shows the request is aborted without doing any inference and only [DONE] is returned on the frontend. They can be solved by this PR.
Issues
opea-project/GenAIExamples#1597
#1300 (comment)
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
na
Tests
na