Update HELMET to support vllm-gaudi #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support OpenAI API compatiable endpoint such as vllm & tgi Validate on Llama3.3-70b-Instruct Signed-off-by: Xinyao Wang <[email protected]>
XinyaoWa
force-pushed
the
helmet_1.3
branch
2 times, most recently
from
f078ac3 to
af3707b
Compare
|
@XinyaoWa could we close this PR because of the merge(princeton-nlp/HELMET#20)? |
Following the suggestion of @minmin-intel , this PR is for GenAIEval, a copy of HELMET, should also be kept. |
Signed-off-by: sys-lpot-val <[email protected]>
chensuyue
approved these changes
Apr 10, 2025
lkk12014402
approved these changes
Apr 10, 2025
|
The CI issue is not related to this PR, will fix in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support OpenAI API compatiable endpoint such as vllm & tgi
Validate on Llama3.3-70b-Instruct
Related HELMET PR: princeton-nlp/HELMET#20
Original implementation refer to minmin's code
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.