-
Notifications
You must be signed in to change notification settings - Fork 301
Open
1 / 11 of 1 issue completedOpen
1 / 11 of 1 issue completed
Copy link
Labels
Milestone
Description
In the nginx.conf for CodeGen React UI, there is a hardcoded port 80.
listen 80; |
Supporting parametrization of nginx port is not a purely cosmetic matter, since it causes issues on unpriviliged deployments on K8s/OpenShift.
It would be good to both:
- switch the default from port 80 to a known-working port outside of 1-1023 range, since it is is privileged by default and requires specific securityContext (which would be a terrible thing to use).
- support parametrizing nginx port in an easy way, which doesn't require rebuilding the image (see the docs for upstream image used: https://hub.docker.com/_/nginx -> Using environment variables in nginx configuration (new in 1.19))
The fastest way to fix the issue would be to just switch port 80 to 8080.
Additionally, might be good to look into using https://hub.docker.com/r/nginxinc/nginx-unprivileged image as base.