Skip to content

Clean up test scripts and enhance git clone #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Jan 20, 2025

Description

Clean up test scripts and enhance git clone:

  1. Clean up test code in scripts.
  2. Simplify git clone code.
  3. Replace git clone branch in Dockerfile.

Issues

Replace the git clone branch with condition, make sure the test code combine with the special test branch.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

2. Simplify git clone code.
3. Replace git clone branch in Dockerfile.

Signed-off-by: chensuyue <[email protected]>
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@chensuyue chensuyue added this to the v1.2 milestone Jan 20, 2025
@chensuyue
Copy link
Collaborator Author

GraphRAG issue will be fixed in #1408

@chensuyue chensuyue merged commit 6bfd156 into main Jan 20, 2025
45 of 46 checks passed
@chensuyue chensuyue deleted the suyue/remove-test-code branch January 20, 2025 08:34
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Mar 4, 2025
1. Clean up test code in scripts.
2. Simplify git clone code.
3. Replace git clone branch in Dockerfile.

Signed-off-by: chensuyue <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants