Skip to content

Fix VideoQnA #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Apr 12, 2025
Merged

Fix VideoQnA #1696

merged 46 commits into from
Apr 12, 2025

Conversation

cwlacewe
Copy link
Contributor

Description

This PR fixes the VideoQnA example.

Issues

Fixes #1476 #1478 #1477
Depends on GenAIComps PR#1317

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

cd VideoQnA/tests
export HF_TOKEN=<Huggingface token>
./test_compose_on_xeon.sh

@cwlacewe cwlacewe requested a review from XinyaoWa as a code owner March 19, 2025 11:15
Copy link

github-actions bot commented Mar 19, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@joshuayao joshuayao added this to the v1.3 milestone Apr 8, 2025
@lvliang-intel
Copy link
Collaborator

@cwlacewe,
please fix the CI issue.
image

@joshuayao joshuayao added this to OPEA Apr 9, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 9, 2025
@joshuayao joshuayao added the bug Something isn't working label Apr 9, 2025
@joshuayao joshuayao linked an issue Apr 9, 2025 that may be closed by this pull request
8 tasks
@yinghu5
Copy link
Collaborator

yinghu5 commented Apr 10, 2025

@cwlacewe one CI for VideoQnA failed. could you please check?
[2025-04-10 02:56:33,543] [ ERROR] - opea_dataprep_multimodal_microservice - Error during dataprep ingest videos invocation: openai/clip-vit-base-patch32 does not appear to have a file named pytorch_model.bin but there is a file for TensorFlow weights. Use from_tf=True to load this model from those weights.
ERROR: Exception in ASGI application
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 403, in run_asgi
result = await app( # type: ignore[func-returns-value]

@joshuayao joshuayao added the v1.3 label Apr 11, 2025
@xiguiw
Copy link
Collaborator

xiguiw commented Apr 11, 2025

CI failure:
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
Permission denied

[2025-04-11 08:21:57,549] [    INFO] - opea_dataprep_vdms_multimodal - Connecting to vdms at 10.244.159.163:8001
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
Could not cache non-existence of file. Will ignore error and continue. Error: [Errno 13] Permission denied: '/home/user/.cache/huggingface/hub/models--openai--clip-vit-base-patch32'
[2025-04-11 08:21:58,100] [   ERROR] - opea_dataprep_multimodal_microservice - Error during dataprep ingest videos invocation: openai/clip-vit-base-patch32 does not appear to have a file named pytorch_model.bin but there is a file for TensorFlow weights. Use `from_tf=True` to load this model from those weights.
ERROR:    Exception in ASGI application

zhanmyz and others added 5 commits April 11, 2025 16:31
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
…opea-project#1369)

Signed-off-by: Eero Tamminen <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
for more information, see https://pre-commit.ci

Signed-off-by: Lacewell, Chaunte W <[email protected]>
pre-commit-ci bot and others added 27 commits April 11, 2025 16:51
Signed-off-by: Sun, Xuehao <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sun, Xuehao <[email protected]>
Co-authored-by: Abolfazl Shahbazi <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: minmin-intel <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
…ct#1604)

Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: Abolfazl Shahbazi <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: sys-lpot-val <[email protected]>
Co-authored-by: sys-lpot-val <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
)

Signed-off-by: ZePan110 <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: minmin-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
… always latest stable version; - Minor updates in README; - Remove debug logs from videoqna.py; - Revert mounting volumes

Signed-off-by: Lacewell, Chaunte W <[email protected]>
…sion denied error with clip model in CI

Signed-off-by: Lacewell, Chaunte W <[email protected]>
… always latest stable version; - Minor updates in README; - Remove debug logs from videoqna.py; - Revert mounting volumes

Signed-off-by: Lacewell, Chaunte W <[email protected]>
…sion denied error with clip model in CI

Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@xiguiw xiguiw merged commit c476343 into opea-project:main Apr 12, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 12, 2025
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
This PR fixes the VideoQnA example.

Fixes Issues opea-project#1476 opea-project#1478 opea-project#1477

Signed-off-by: zhanmyz <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.3
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] VideoQnA failed on Xeon