Skip to content

Update set_env.sh to add REDIS_HOST #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Update set_env.sh to add REDIS_HOST #644

merged 2 commits into from
Aug 22, 2024

Conversation

yinghu5
Copy link
Collaborator

@yinghu5 yinghu5 commented Aug 22, 2024

Description

fix issue #591
set_env.sh for ChantQnA on Xeon is missing the REDIS_HOST environment variable. because of that when do docker compose up -d, the retriever-redis-server container is showing errors. I solved the problem by adding export REDIS_HOST=${host_ip} Perhaps the same change in needed in other examples as well.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

[-] Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

fix issue #591 
set_env.sh for ChantQnA on Xeon is missing the REDIS_HOST environment variable. because of that when do docker compose up -d, the retriever-redis-server container is showing errors. I solved the problem by adding export REDIS_HOST=${host_ip}
Perhaps the same change in needed in other examples as well.
@yinghu5 yinghu5 requested a review from lvliang-intel as a code owner August 22, 2024 00:59
@yinghu5 yinghu5 requested a review from kevinintel August 22, 2024 01:07
@chensuyue chensuyue merged commit 9657f7b into main Aug 22, 2024
15 checks passed
@chensuyue chensuyue deleted the yinghu5-patch-1 branch August 22, 2024 08:02
dmsuehir pushed a commit to dmsuehir/GenAIExamples that referenced this pull request Sep 11, 2024
wangkl2 pushed a commit to wangkl2/GenAIExamples that referenced this pull request Dec 11, 2024
* fixjsonl

Signed-off-by: XuhuiRen <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: XuhuiRen <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants