Handle uncontrolled data path for MultimodalQnA v1.0 release #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiep Le <[email protected]>
for more information, see https://pre-commit.ci
|
@chensuyue Can you please check if this PR is able to fix the alert from code scanning? |
tileintel
changed the title
chensuyue
approved these changes
Sep 19, 2024
letonghan
approved these changes
Sep 19, 2024
polszewska
pushed a commit
to polszewska/GenAIExamples
that referenced
this pull request
Sep 20, 2024
…oject#845) Signed-off-by: Tiep Le <[email protected]>
wangkl2
pushed a commit
to wangkl2/GenAIExamples
that referenced
this pull request
Dec 11, 2024
* Fix typos in BaseStatistics method names Signed-off-by: Eero Tamminen <[email protected]> * Add HttpService "inprogress" (pending) request count metrics Signed-off-by: Eero Tamminen <[email protected]> * Add E2E Prometheus metrics to ServiceOrchestrator Signed-off-by: Eero Tamminen <[email protected]> * Fix: support metrics with multiple ServiceOrchestrator instances Unlike apps, CI tests create multiple of them. Signed-off-by: Eero Tamminen <[email protected]> * Fix: require named MicroService -> HTTPService instances Creating multiple MicroService()s creates multiple HTTPService()s which creates multiple Prometheus fastapi instrumentor instances. While latter handled that fine for ChatQnA and normal HTTP metrics, that was not the case for its "inprogress" metrics in CI. Therefore MicroService constructor name argument is now mandatory, so that it can be used to make "inprogress" metrics for HTTPService instances unique. PS. instrumentor requires HTTPService instance specific Starlette instance, so it cannot be made singleton. Signed-off-by: Eero Tamminen <[email protected]> * Fix: update test_token_generator() Signed-off-by: Eero Tamminen <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Eero Tamminen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix code scanning alert for uncontrolled data used in path expression for MultimodalQnA for v1.0 release
Issues
#833
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
N/A