Skip to content

Commit f9204f0

Browse files
KfreeZzhlsunshine
andauthored
fix #314 (#359)
* fix #314 Signed-off-by: KfreeZ <[email protected]> * fix #314 Signed-off-by: KfreeZ <[email protected]> --------- Signed-off-by: KfreeZ <[email protected]> Co-authored-by: Steve Zhang <[email protected]>
1 parent 19fe1a2 commit f9204f0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.github/workflows/scripts/e2e/gmc_xeon_test.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -452,10 +452,14 @@ function validate_modify_config() {
452452
#change the model id of the step named "Tgi" in the codegen_xeon_mod.yaml
453453
yq -i '(.spec.nodes.root.steps[] | select ( .name == "Tgi")).internalService.config.MODEL_ID = "HuggingFaceH4/mistral-7b-grok"' $(pwd)/config/samples/CodeGen/codegen_xeon_mod.yaml
454454
kubectl apply -f $(pwd)/config/samples/CodeGen/codegen_xeon_mod.yaml
455-
#you are supposed to see an error, it's a known issue, but it does not affect the tests
456-
#https://github.com/opea-project/GenAIInfra/issues/314
457455

458-
pods_count=$(kubectl get pods -n $MODIFY_STEP_NAMESPACE -o jsonpath='{.items[*].metadata.name}' | wc -w)
456+
# Wait until all pods are ready
457+
wait_until_all_pod_ready $MODIFY_STEP_NAMESPACE 300s
458+
if [ $? -ne 0 ]; then
459+
echo "Error Some pods are not ready!"
460+
exit 1
461+
fi
462+
459463
check_gmc_status $MODIFY_STEP_NAMESPACE 'codegen' $pods_count 0 3
460464
if [ $? -ne 0 ]; then
461465
echo "GMC status is not as expected"

0 commit comments

Comments
 (0)