fix #314 #359
Merged
fix #314 #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: KfreeZ <[email protected]>
irisdingbj
approved these changes
Aug 29, 2024
lianhao
reviewed
Aug 29, 2024
|
|
||
| pods_count=$(kubectl get pods -n $MODIFY_STEP_NAMESPACE -o jsonpath='{.items[*].metadata.name}' | wc -w) | ||
| # Wait until all pods are ready | ||
| wait_until_all_pod_ready $MODIFY_STEP_NAMESPACE 300s |
There was a problem hiding this comment.
This could leads test failure. wait_until_all_pod_ready doesn't support the case when some pods are being deleted.
There was a problem hiding this comment.
thanks for reminding, I will keep monitoring it.
There was a problem hiding this comment.
Could you please enhance wait_until_all_pod_ready so it can omit those pods with Terminating status when it tries to get the list of pods to wait for ready?
There was a problem hiding this comment.
yes, I am just about to do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is a fix for #314
root cause: the error happens when script was trying to delete the pipeline before the update is done.
solution: to avoid the error when delete the pipeline, wait for all pods ready, then delete.
Issues
#314
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
'n/a'
Tests
CI/CD is covering this