Upgrade tgi and tei version #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is due to an GenAIExample change, which will be fixed at #910 |
poussa
approved these changes
Apr 2, 2025
Use 2.4.1 for GPU. Others already synced with Gaudi 2.3.1 and cpu 2.4.0-intel-cpu Signed-off-by: Dolpher Du <[email protected]>
Signed-off-by: Dolpher Du <[email protected]>
lianhao
reviewed
Apr 2, 2025
There was a problem hiding this comment.
@yongfengdu maybe we should remove liveliness check for both tei/teirerank/tgi ?
yongfengdu
force-pushed
the
tgitei
branch
2 times, most recently
from
2f467bf to
e5e0d7d
Compare
I tried to remove the tgi/tei/teirerank livenessProbe, but we also need to remove the tgi/tei/teirerank livenessProbe settings in all Examples, which will trigger a bigger test matrix. (Otherwise helm will report error) |
lianhao
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the TGI and TEI to be consistent with compose deployment
Issues
#921 #906
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.