Add timing functionality #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasm307
force-pushed
the
feat/add-timing-functionality
branch
4 times, most recently
from
0b52ec7 to
9f70e6a
Compare
eliasm307
force-pushed
the
feat/add-timing-functionality
branch
from
de60210 to
fbda2f7
Compare
eliasm307
force-pushed
the
feat/add-timing-functionality
branch
from
fbda2f7 to
2bc5bcc
Compare
Member
gustavohenke
left a comment
gustavohenke
left a comment
There was a problem hiding this comment.
whoaa this is super nice! I've added a bunch of thoughts, let me know what you think please.
There are some styling inconsistencies (but these aren't defined anywhere!), so I'll fix them up when we've agreed on the discussion below.
eliasm307
force-pushed
the
feat/add-timing-functionality
branch
2 times, most recently
from
18c911e to
3487f83
Compare
Contributor
Author
|
@gustavohenke thanks for the feedback, I've applied it, let me know if you see anything else |
eliasm307
force-pushed
the
feat/add-timing-functionality
branch
3 times, most recently
from
6da8b2c to
596c9de
Compare
Co-authored-by: Gustavo Henke <[email protected]>
eliasm307
force-pushed
the
feat/add-timing-functionality
branch
from
596c9de to
7eb0499
Compare
Contributor
Author
|
@gustavohenke the test coverage being almost 100% was annoying me so I've added a few tests to cover the remaining lines |
gustavohenke
approved these changes
Dec 5, 2021
Member
gustavohenke
left a comment
gustavohenke
left a comment
There was a problem hiding this comment.
Thanks! LGTM, I'm just implementing a logger-friendly console.table and will push directly to your branch.
We need to respect a bunch of other combinations users can have (raw mode, using a custom stdout, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timing functionality to resolve #291