Skip to content

🐛 release-0.11 branch - Bring back application-manager addon and remove argocd-addon #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mikeshng
Copy link
Member

@mikeshng mikeshng commented May 29, 2025

Summary

For release-0.11 branch only: Bring back application-manager addon and remove argocd-addon by reverting main branch commit 3d8291d16c8baf82e3799f495106b26393fcc4a2

Related issue(s)

Fixes #489

@openshift-ci openshift-ci bot requested review from dhaiducek and gparvin May 29, 2025 13:47
@mikeshng
Copy link
Member Author

/assign @qiujian16

@mikeshng mikeshng changed the title 🐛 release-0.11branch - Bring back application-manager addon and remove argocd-addon 🐛 release-0.11 branch - Bring back application-manager addon and remove argocd-addon May 29, 2025
@mikeshng
Copy link
Member Author

Sorry @qiujian16 we might have to do another patch release to bring the old application-manager add-on back. Please let me know if you want me to try to do a release.

@qiujian16
Copy link
Member

/approve
/lgtm

@mikeshng you will need to update the version.go and tag the new release after.

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2025
Copy link

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 346c385 into open-cluster-management-io:release-0.11 Jun 3, 2025
10 checks passed
@mikeshng mikeshng deleted the 0-11-revert-argocd-addon branch June 3, 2025 10:15
@mikeshng
Copy link
Member Author

mikeshng commented Jun 3, 2025

@mikeshng you will need to update the version.go and tag the new release after.

@qiujian16 I am not moving up the OCM version tho. I am just bringing the old application-manager addon back. I don't think I need to make the changes in https://github.com/open-cluster-management-io/clusteradm/pull/491/files Please confirm. Thanks!

Also, can I do a pre-release first so @nirs and his team can test it out before the actual release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants