Skip to content

Conversation

Xiao-Youth
Copy link

Motivation

This PR adds support for the GrandPhysics dataset to OpenCompass. GrandPhysics is a evaluation dataset (not yet publicly available) built from A Grand Dictionary of Physics Problems and Solutions (物理学大题典). Dataset file need to be uploaded to OSS.
GrandPhysics_50_questions.json

Modification

  1. Dataset file: opencompass/datasets/grand_physics.py

  2. Dataset evaluation configuration: opencompass/configs/datasets/GrandPhysics/GrandPhysics_llm_judge_gen.py

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As inline comments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the package version for the pre-commit hooks. If you need to change them, please provide the corresponding reasons.

@tonysy
Copy link
Collaborator

tonysy commented Jun 5, 2025

Also please fix the conflicts via git reabse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants