-
Notifications
You must be signed in to change notification settings - Fork 854
[V2]: Remove task type #2450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2]: Remove task type #2450
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #2450 +/- ##
=============================================
Coverage ? 78.16%
=============================================
Files ? 307
Lines ? 13076
Branches ? 0
=============================================
Hits ? 10221
Misses ? 2855
Partials ? 0 ☔ View full report in Codecov by Sentry. |
samet-akcay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
massive trimming, thanks!
📝 Description
AnomalibDatasetclass still requires a notion oftask_typeto determine if it should include an empty mask in the dataset item for normal samples. Instead of passing an explicittask_typeparameter to the class instance, we now infer the task type from the availability of ground truth masks on the file system, and store the inferred task type as metadata in the samples dataframe. A newtaskproperty was added to bothAnomalibDatamoduleandAnomalibDatasetto easily retrieve the inferred task type when needed.✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.