Skip to content

feat: OFREP web provider#776

Merged
thomaspoignant merged 45 commits intomainfrom
ofrep-web-provider-poc
Apr 5, 2024
Merged

feat: OFREP web provider#776
thomaspoignant merged 45 commits intomainfrom
ofrep-web-provider-poc

Conversation

@thomaspoignant
Copy link
Copy Markdown
Member

This is a long-running PR for the OFREP-web provider, the goal is to use this to use this PR to test the implementation of the OpenFeature Remote Evaluation Protocol to understand the limit of the protocol.

Check open-feature/protocol to know more about it.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch from 88c2675 to 9ec4dca Compare March 18, 2024 13:09
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch from ccd8982 to 75f7547 Compare March 25, 2024 17:28
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch from 72de523 to bb249bc Compare March 25, 2024 17:32
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Comment thread libs/providers/ofrep-web/src/lib/ofrep-web-provider.ts Outdated
Comment thread libs/providers/ofrep-web/src/lib/model/ofrep-web-provider-options.ts Outdated
Comment thread libs/providers/ofrep-web/src/lib/ofrep-web-provider.spec.ts
Comment thread libs/providers/ofrep-web/src/lib/ofrep-web-provider.ts Outdated
Comment thread libs/providers/ofrep-web/src/lib/ofrep-web-provider.ts Outdated
Comment thread libs/providers/ofrep-web/src/lib/ofrep-web-provider.ts Outdated
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant marked this pull request as ready for review March 29, 2024 20:06
@thomaspoignant thomaspoignant requested a review from a team as a code owner March 29, 2024 20:06
beeme1mr and others added 5 commits March 29, 2024 16:37
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant changed the title feat: OFREP web provider POC feat: OFREP web provider Apr 4, 2024
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch 2 times, most recently from 48688f1 to 55262de Compare April 4, 2024 19:44
Copy link
Copy Markdown
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found one nit, otherwise this looks great!
Really looking forward! :)

Comment thread libs/providers/ofrep-web/src/lib/ofrep-web-provider.ts Outdated
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch from 55262de to 2f92219 Compare April 4, 2024 19:45
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch from 1079d28 to c3c9076 Compare April 4, 2024 20:04
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch from beda447 to 9da3a6d Compare April 5, 2024 13:39
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@beeme1mr
Copy link
Copy Markdown
Member

beeme1mr commented Apr 5, 2024

Should we try and release today?

@thomaspoignant
Copy link
Copy Markdown
Member Author

Should we try and release today?

That would be awesome.
I'll release it now.

@thomaspoignant thomaspoignant merged commit 9626ef4 into main Apr 5, 2024
@thomaspoignant thomaspoignant deleted the ofrep-web-provider-poc branch April 5, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants