feat: Add evaluation options to FeatureFlag component#1322
Conversation
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Summary of ChangesHello @marcozabel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds evaluationOptions to the FeatureFlag component, allowing consumers to pass options like suspend to the underlying useFlag hook. The changes are well-implemented and include tests for the new suspense functionality. I've made a couple of suggestions to improve the test code's robustness and clarity. Overall, this is a good addition.
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
🤖 I have created a release *beep* *boop* --- ## [1.2.0](react-sdk-v1.1.0...react-sdk-v1.2.0) (2026-01-16) ### ✨ New Features * Add evaluation options to FeatureFlag component ([#1322](#1322)) ([f3f3685](f3f3685)) * **react:** add FeatureFlag component ([#1164](#1164)) ([e7a5fb5](e7a5fb5)) ### 🐛 Bug Fixes * infer domain from client for useContextMutator setContext ([#1317](#1317)) ([49e664f](49e664f)) * remove explicit return type for React `OpenFeatureProvider` ([#1313](#1313)) ([fb6cdc9](fb6cdc9)) ### 📚 Documentation * **react:** fix type in declarative testing example ([#1323](#1323)) ([aebc2aa](aebc2aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
This PR
This PR is adding evaluation options to the FeatureFlag component to allow the use of suspend options.
Related Issues
#1321
Notes
Follow-up Tasks
How to test