Add support of TorchVision's Model Registration API on MMAction2 #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hukkai
approved these changes
Sep 8, 2022
|
@datumbox Thanks for the new feature! The lint is failed. Please allow me to fix the lint. |
|
@datumbox Thank you very much for your help. Could you please sign the CLA so we can accept your contribution? |
|
@hukkai Apologies, thanks for fixing the linter for me! @ly015 I have submitted a request to my company to approve the signing of the CLA (similar to open-mmlab/mmcv#2246 (comment)). I don't expect any blockers but it might take up to a week to complete. Sorry for the delay, hopefully with this completed, I would be able to contribute easier going forwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to open-mmlab/mmcv#2246, but doesn't depend on it. We focus on using the new methods introduced by TorchVision's Model Registration API.
It adopts the new
torchvision.models.get_model()method to initialize a model by its name instead of using directlytorchvision.models.__dict__.Looking forward to your feedback (see pytorch/vision#6365).