support moore threads MUSA gpu，split PR 1. #3241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
reviewed
Feb 19, 2025
mmcv/ops/csrc/pytorch/spconv_utils.h
Outdated
| #include "pytorch_cuda_helper.hpp" | ||
|
|
||
| namespace tv { | ||
| #ifdef MMCV_WITH_CUDA |
Collaborator
There was a problem hiding this comment.
Struct GPU maybe used by other devices like MLU or NPU, this may lead to BC.
| pytest.mark.skipif( | ||
| IS_MUSA_AVAILABLE, | ||
| reason='MUSA does not support for 64-bit floating point') | ||
| ]), torch.half |
Contributor
Author
There was a problem hiding this comment.
fix, pls check,ths
grimoire
approved these changes
Feb 20, 2025
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
support moore threads MUSA gpu，split PR 1.
Modification
Due to compatibility with cuda, cuda operators can be directly ported
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR:
Other openmmlab supports musa PR
open-mmlab/mmengine#1453