Skip to content

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add TVM support.

Modification

  • TVM builder
  • AUTOTVM and ANSOR Tuner support
  • SDK support

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@grimoire grimoire changed the title [WIP] Support tvm [Enhancement] Support tvm Nov 7, 2022
@tpoisonooo
Copy link
Collaborator

  1. missing how_to_build.md, I do not know how to install tvm after reading mmdeploy doc.
  2. how about adding script install tvm backend
  3. missing tvm CI

Copy link
Collaborator

@lzhangzz lzhangzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@open-mmlab open-mmlab locked and limited conversation to collaborators Dec 7, 2022
@open-mmlab open-mmlab unlocked this conversation Dec 7, 2022
@grimoire
Copy link
Member Author

grimoire commented Dec 7, 2022

Do not merge now. find bugs in sdk.

@grimoire
Copy link
Member Author

grimoire commented Dec 7, 2022

Fixed.

@lvhan028
Copy link
Collaborator

lvhan028 commented Dec 8, 2022

get an error in ci/circleci: test_windows_onnxruntime, but I haven't figured it out.

@lvhan028
Copy link
Collaborator

lvhan028 commented Dec 8, 2022

@irexyc

@lvhan028 lvhan028 requested a review from irexyc December 8, 2022 13:14
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@lvhan028 lvhan028 merged commit 7cb4b9b into open-mmlab:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants