Skip to content

Conversation

PeterH0323
Copy link
Contributor

@PeterH0323 PeterH0323 commented Dec 4, 2022

Motivation

When using USE_SRC_INSIDE=true the pip source still the original. Since the user want to use USE_SRC_INSIDE so we need to switch the source of pip as well

Modification

Add pip source. And speed up the download for pip . 🚀

@PeterH0323 PeterH0323 changed the title [Improve] Improve dockerfile conda and pip source [Improve] Improve dockerfile pip source Dec 4, 2022
@AllentDan
Copy link
Member

Hi, the same to the CPU dockerfile please.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028
Copy link
Collaborator

lvhan028 commented Dec 6, 2022

@PeterH0323 Could you please pull another PR to the master branch?

@lvhan028 lvhan028 merged commit a964790 into open-mmlab:dev-1.x Dec 6, 2022
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
* [Improve] Improve dockerfile conda and pip source

* Update Dockerfile

* import cpu dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants