Skip to content

Conversation

kota-iizuka
Copy link
Contributor

@kota-iizuka kota-iizuka commented Dec 21, 2022

Motivation

Make inference possible with partition model as well as End2EndModel.

Modification

Fixed predict function name of PartitionSingleStageModel and PartitionTwoStageModel from forward_test to predict.

BC-breaking (Optional)

Nothing.

Use cases (Optional)

Adding no feature.

Checklist

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
    • This function does not depend on other projects.
  • The documentation has been modified accordingly, like docstring or example tutorials.
    • Document of prediction functions are same as other models.

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@kota-iizuka kota-iizuka force-pushed the fix_mmdet_backend_model branch from 09c4346 to e535638 Compare December 21, 2022 02:16
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 85be66f into open-mmlab:dev-1.x Dec 22, 2022
@kota-iizuka kota-iizuka deleted the fix_mmdet_backend_model branch December 23, 2022 02:21
@OpenMMLab-Assistant001
Copy link

Hi @kota-iizuka !First of all, we want to express our gratitude for your significant PR in the MMDeploy project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants