Skip to content

Fixed miniconda.sh errors in Dockerfile #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fixed miniconda.sh errors in Dockerfile #1599

merged 1 commit into from
Jan 10, 2023

Conversation

nghiaho12
Copy link
Contributor

When building the Docker image following the official instructions

docker build docker/CPU/ -t mmdeploy:master-cpu

it fails to run /root/minicnoda.sh with the following errors

Downloading and Extracting Packages


Downloading and Extracting Packages

Preparing transaction: ...working... done
Executing transaction: ...working... done
/root/miniconda.sh: 438: /root/miniconda.sh: [[: not found

Installing * environment...

/root/miniconda.sh: 444: /root/miniconda.sh: [[: not found

This PR fixes it by calling the script explicitly with bash.

@CLAassistant
Copy link

CLAassistant commented Dec 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lvhan028 lvhan028 requested a review from AllentDan January 3, 2023 02:51
AllentDan
AllentDan approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 1b048d8 into open-mmlab:master Jan 10, 2023
@lvhan028
Copy link
Collaborator

Hi, @nghiaho12
could you pull another request for dev-1.x?

@nghiaho12
Copy link
Contributor Author

Just created the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@AllentDan AllentDan AllentDan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nghiaho12 @CLAassistant @lvhan028 @AllentDan